Skip to content

Add ur_calibration package #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2022
Merged

Add ur_calibration package #451

merged 3 commits into from
Oct 5, 2022

Conversation

@fmauch
Copy link
Contributor

@fmauch fmauch commented Jul 27, 2022

Closes #384

@fmauch fmauch requested a review from RobertWilbrandt July 27, 2022 10:06
@fmauch fmauch added this to the ROS1 feature parity milestone Jul 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022 •
edited by codecov bot
Loading

Codecov Report

❗ No coverage uploaded for pull request base (foxy@69c2030). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@          Coverage Diff           @@
##             foxy    #451   +/-   ##
======================================
  Coverage        ?   3.73%           
======================================
  Files           ?      16           
  Lines           ?    1071           
  Branches        ?     212           
======================================
  Hits            ?      40           
  Misses          ?     942           
  Partials        ?      89
Flag Coverage Δ
unittests 3.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmauch fmauch added the Foxy label Aug 1, 2022
@fmauch fmauch requested a review from urmahp September 26, 2022 07:21
urmahp
urmahp approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should have some description on how to launch the driver with the extracted kinematics, similar to what we have in the ROS Driver.

Other than a small typo and above it looks good, I have tested that it works with a real robot. I will be approving this PR, but I think we should consider adding above to the main README before merging.

fmauch and others added 2 commits October 4, 2022 09:29
@fmauch @urmahp
Update ur_calibration/README.md
d3c2b4c 
Co-authored-by: Mads Holm Peters <[email protected]>
@fmauch @urmahp
Update ur_calibration/README.md
708ce88 
Co-authored-by: Mads Holm Peters <[email protected]>
@fmauch fmauch mentioned this pull request Oct 4, 2022
Merged
@fmauch
Copy link
Contributor Author

fmauch commented Oct 5, 2022

I'll merge it like this and then create a separate PR regarding the usage, as we'll need that on all three branches.

@fmauch fmauch merged commit e448b15 into UniversalRobots:foxy Oct 5, 2022
@fmauch fmauch deleted the foxy_calibration branch October 5, 2022 08:03
@fmauch fmauch mentioned this pull request Oct 5, 2022
Closed
@fmauch fmauch mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urmahp urmahp urmahp approved these changes

@RobertWilbrandt RobertWilbrandt Awaiting requested review from RobertWilbrandt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ROS1 feature parity

Development

Successfully merging this pull request may close these issues.

3 participants

@fmauch @codecov-commenter @urmahp